Update trace.py tests / fix some warnings #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryevdv
commented
Apr 28, 2022
| @@ -97,7 +97,7 @@ def is_supported_dtype(dtype: Any) -> bool: | |||
|
|
|||
|
|
|||
| def calculate_volume(shape: tuple[int, ...]) -> int: | |||
| if shape == (): | |||
| if len(shape) == 0: | |||
There was a problem hiding this comment.
@magnatelee This was causing a warning because sometimes the shape passed in was a numpy array. This seems like an OK immediate fix until more in-depth typing work is started (and the proper fix in any case if arrays are valid inputs)
There was a problem hiding this comment.
yeah I noticed the same warning today and put in exactly the same fix in my local change. I'll chase down where the numpy array is being passed and fix it as well
bryevdv
changed the title
manopapad
added a commit
to manopapad/cunumeric
that referenced
this pull request
Sep 7, 2022
* Required core changes for cunumeric#474 * Don't expose Storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates and moves the
trace.pytest that missed #297This PR also fixes a few warning conditions that were being reported at the end of pytest runs