Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message on unsupported complex reductions #300

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Better error message on unsupported complex reductions #300

merged 1 commit into from
Apr 22, 2022

Conversation

manopapad
Copy link
Contributor

No description provided.

@magnatelee
Copy link
Contributor

LGTM

@manopapad manopapad merged commit 779bfc6 into nv-legate:branch-22.05 Apr 22, 2022
@bryevdv
Copy link
Contributor

bryevdv commented Apr 22, 2022

FYI after the pytest PR is merged with pytest.raises can be used to maintain both the exception type and (if desired) the exception message in situations like this.

ipdemes pushed a commit to ipdemes/cunumeric that referenced this pull request Aug 4, 2022
@magnatelee
Eliminate shift transforms that are no-op (nv-legate#300)
1bffbb6
@manopapad manopapad deleted the complex-minmax branch July 19, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnatelee magnatelee magnatelee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manopapad @magnatelee @bryevdv