Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: adding logic for DIAGONAL #170

Merged
merged 6 commits into from
Jan 29, 2022
Merged

WIP: adding logic for DIAGONAL #170

merged 6 commits into from
Jan 29, 2022

Conversation

ipdemes
Copy link
Contributor

@ipdemes ipdemes commented Jan 11, 2022

No description provided.

@ipdemes ipdemes force-pushed the diagonal_operation branch 6 times, most recently from 52d95dc to 340f93f Compare January 13, 2022 18:08
manopapad
manopapad reviewed Jan 24, 2022
View reviewed changes
cunumeric/eager.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 24, 2022
View reviewed changes
cunumeric/eager.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 24, 2022
View reviewed changes
cunumeric/thunk.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 24, 2022
View reviewed changes
cunumeric/module.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 24, 2022
View reviewed changes
cunumeric/module.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 24, 2022
View reviewed changes
cunumeric/module.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 24, 2022
View reviewed changes
cunumeric/eager.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 24, 2022
View reviewed changes
cunumeric/array.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 24, 2022
View reviewed changes
cunumeric/deferred.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 24, 2022
View reviewed changes
cunumeric/module.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 24, 2022
View reviewed changes
cunumeric/deferred.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 25, 2022
View reviewed changes
cunumeric/array.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 25, 2022
View reviewed changes
cunumeric/eager.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 25, 2022
View reviewed changes
cunumeric/array.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 25, 2022
View reviewed changes
cunumeric/array.py Outdated Show resolved Hide resolved
@manopapad
Copy link
Contributor

Once you're done with other changes, please add a docstring to the public-facing APIs, linking to the corresponding NumPy API:

https://numpy.org/doc/stable/reference/generated/numpy.diag.html
https://numpy.org/doc/stable/reference/generated/numpy.diagonal.html#numpy.diagonal
https://numpy.org/doc/stable/reference/generated/numpy.ndarray.diagonal.html

and noting the differences in the cuNumeric implementation:

  • we never return a view
  • we support some extra arguments (extract and axes), with their usage restrictions

@magnatelee magnatelee mentioned this pull request Jan 27, 2022
Closed
manopapad
manopapad reviewed Jan 28, 2022
View reviewed changes
cunumeric/module.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 28, 2022
View reviewed changes
cunumeric/module.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 28, 2022
View reviewed changes
cunumeric/eager.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 28, 2022
View reviewed changes
cunumeric/module.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Jan 28, 2022
View reviewed changes
cunumeric/module.py Outdated Show resolved Hide resolved
@manopapad
Copy link
Contributor

No further comments, feel free to merge

@ipdemes ipdemes merged commit c95d364 into nv-legate:branch-22.01 Jan 29, 2022
fduguet-nv pushed a commit to fduguet-nv/cunumeric that referenced this pull request Mar 29, 2022
@manopapad
Merge pull request nv-legate#170 from manopapad/march
2b497f6 
Add install.py flag to feed -march to legion and legate
@ipdemes ipdemes deleted the diagonal_operation branch June 13, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnatelee magnatelee magnatelee left review comments

@manopapad manopapad manopapad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipdemes @manopapad @magnatelee