Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .cu for CUDA library management #145

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

magnatelee
Copy link
Contributor

This PR is to put the CUDA library management code in a .cu file instead of a .cc file. We've been going headerless for CUDA library handles to avoid duplicate definitions of the half float type in a .cc file, but this trick won't work for cuTENSOR whose handle is a struct with a fixed size array instead of just a pointer. So, we use .cu instead so that we can include CUDA library headers in this code.

@magnatelee magnatelee merged commit 8b2357a into nv-legate:branch-22.01 Dec 8, 2021
@magnatelee magnatelee deleted the cudalib-fix branch December 8, 2021 01:59
fduguet-nv pushed a commit to fduguet-nv/cunumeric that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant