Fix for control replication violation in test #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manopapad
reviewed
Jul 25, 2023
scripts/hooks/enforce_boilerplate.py
Outdated
| @@ -17,6 +17,8 @@ | |||
| from typing import NoReturn | |||
|
|
|||
| BOILERPLATE = [ | |||
There was a problem hiding this comment.
This code will need to be present at the bottom of every test, otherwise pre-commit checks will fail.
There was a problem hiding this comment.
Actually let's just remove this for now. I think we're going to end up seeding np.random and python random automatically on import legate.
manopapad
reviewed
Jul 25, 2023
ipdemes
added
the
category:bug-fix
manopapad
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several tests used python's random which will generate different values on a different Legion shards. This violates control replication requirements.