Skip to content

Commit

Permalink
Misc small updates (#352)
Browse files Browse the repository at this point in the history
* add missing annotations

* remove old conda env file

* specify min mypy version

* update README
  • Loading branch information
bryevdv authored May 13, 2022
1 parent e158f79 commit d32eb73
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 33 deletions.
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,10 @@ cuNumeric requires the following:
- GNU Make
- C++17 compatible compiler (g++, clang, or nvc++)
- Fortran compiler (for building OpenBLAS; not necessary if you provide a pre-built version of OpenBLAS)
- the Python packages listed in `conda/cunumeric_dev.yml`
- the Python packages listed in any one of the conda environment files:
- `conda/environment-test-3.8.yml`
- `conda/environment-test-3.9.yml`
- `conda/environment-test-3.10.yml`

See the [corresponding section](https://github.com/nv-legate/legate.core#dependencies)
on the Legate Core instructions for help on installing the required Python packages
Expand Down
26 changes: 0 additions & 26 deletions conda/cunumeric_dev.yml

This file was deleted.

2 changes: 1 addition & 1 deletion conda/environment-test-3.10.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ dependencies:
- clang-tools>=8
- coverage
- mock
- mypy
- mypy>=0.942
- pre-commit
- pynvml
- pytest
Expand Down
2 changes: 1 addition & 1 deletion conda/environment-test-3.8.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ dependencies:
- clang-tools>=8
- coverage
- mock
- mypy
- mypy>=0.942
- pre-commit
- pynvml
- pytest
Expand Down
2 changes: 1 addition & 1 deletion conda/environment-test-3.9.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ dependencies:
- clang-tools>=8
- coverage
- mock
- mypy
- mypy>=0.942
- pre-commit
- pynvml
- pytest
Expand Down
6 changes: 3 additions & 3 deletions cunumeric/coverage.py
Original file line number Diff line number Diff line change
Expand Up @@ -257,13 +257,13 @@ def decorator(cls: type) -> type:
return decorator


def is_implemented(obj):
def is_implemented(obj: Any) -> bool:
return hasattr(obj, "_cunumeric") and obj._cunumeric.implemented


def is_single(obj):
def is_single(obj: Any) -> bool:
return hasattr(obj, "_cunumeric") and obj._cunumeric.single


def is_multi(obj):
def is_multi(obj: Any) -> bool:
return hasattr(obj, "_cunumeric") and obj._cunumeric.multi

0 comments on commit d32eb73

Please sign in to comment.