feat(SelectMenu): add loading state on async search #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mcastagnetti
force-pushed
the
feat/add-loading-state
branch
from
73d0533
to
bf4f452
Compare
|
@benjamincanac, I successfully rebased the branch on the |
|
Closing this in favor of 3258167. You can now use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SelectMenu component is missing a loading state that informs the user when a process is ongoing. I have added a simple implementation to exhibit this behaviour.
It doesn't use the
loadingprop since it disables the component and does not truly represent the anticipated state.I chose to keep this functionality internal to the component and not expose it as a prop, as it seems more natural for the
isSearchingstate to activate as soon as the user begins typing, rather than at the expiration of the debounce delay.Let me know what you think!
Screen.Recording.2023-08-10.at.10.01.53.mov
Screen.Recording.2023-08-10.at.10.02.11.mov