feat(Tabs): handle icon in items
#1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamincanac
changed the title
iconicon in items
benjamincanac
requested changes
Jul 1, 2024
There was a problem hiding this comment.
Sorry for the delay!
Would you mind adding the icon property to the items at the beginning of the docs? https://github.com/nuxt/ui/pull/1798/files#diff-df0c0c0e8a1f3de6219cf222e8e76c43174704646ec5277dbe9801d9f9a5d6b4R13
Might be worth adding an icons to each examples like you did for the slot 😊
|
Could you also fix the lint? |
benjamincanac
approved these changes
Jul 23, 2024
binhtranhuu
pushed a commit
to binhtranhuu/nuxt-ui
that referenced
this pull request
Jul 28, 2024
Co-authored-by: Benjamin Canac <[email protected]>
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolve #1513
❓ Type of change
📚 Description
Adding an
iconslot to theUTabscomponent, allowing user to making simpler for basic usecase and customizable for advance.📝 Checklist
--
(Thanks @noook for showing/assigning me this issue 🫶)