Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kit): include types in module dist/runtime/ in tsconfig file #28237

Merged
merged 2 commits into from
Jul 21, 2024
Merged

fix(kit): include types in module dist/runtime/ in tsconfig file #28237

merged 2 commits into from
Jul 21, 2024

Conversation

HigherOrderLogic
Copy link
Contributor

🔗 Linked issue

Resolves #28224.

📚 Description

Include types in the dist folder.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jul 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

danielroe
danielroe approved these changes Jul 20, 2024
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Did you confirm whether it resolved the linked issue with sidebase?

@danielroe danielroe changed the title fix: include types in modules dist in tsconfig file fix(kit): include types in module dist/ in tsconfig file Jul 20, 2024
@danielroe danielroe changed the title fix(kit): include types in module dist/ in tsconfig file fix(kit): include types in module dist/runtime/ in tsconfig file Jul 20, 2024
@danielroe danielroe merged commit c0ec90d into nuxt:main Jul 21, 2024
41 checks passed
@github-actions github-actions bot mentioned this pull request Jul 21, 2024
Draft
@trc-mathieu
Copy link

Thank you, it does fix the issue with sidebase and local modules

danielroe pushed a commit that referenced this pull request Jul 23, 2024
@HigherOrderLogic @danielroe
fix(kit): include module dist/runtime/ in tsconfig includes (#28237)
0bbd06b
@github-actions github-actions bot mentioned this pull request Jul 23, 2024
Closed
5 tasks
@github-actions github-actions bot mentioned this pull request Aug 8, 2024
Merged
5 tasks
@Abhishek-Mallick Abhishek-Mallick mentioned this pull request Sep 14, 2024
Merged
@gretchelin gretchelin mentioned this pull request Sep 26, 2024
Merged
@WontonSam WontonSam mentioned this pull request Oct 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong module resolution in tsconfig.json file
3 participants
@HigherOrderLogic @trc-mathieu @danielroe