Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add homepage and repo directory to package.jsons #24189

Merged
merged 5 commits into from
Nov 8, 2023
Merged

chore: add homepage and repo directory to package.jsons #24189

merged 5 commits into from
Nov 8, 2023

Conversation

maximepvrt
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Nov 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@maximepvrt
Copy link
Contributor Author

maximepvrt commented Nov 8, 2023 •
edited
Loading

@danielroe why did you replace the short syntax for repository in the root package.json in the last commit ? for other packages shouldn't a directory in repository be defined 54529c1

@danielroe
Copy link
Member

@maximepvrt Yes, a directory would be good - any chance you could update in this PR? ❤️

@maximepvrt
Copy link
Contributor Author

@danielroe updated

danielroe
danielroe reviewed Nov 8, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@danielroe danielroe changed the title add hompage to package.json chore: add homepage and repo directory to package.jsons Nov 8, 2023
@danielroe @DamianGlowala
chore: remove trailing slash
ee2e9aa 
Co-authored-by: Damian Głowala <[email protected]>
@danielroe danielroe merged commit dd6cc9e into nuxt:main Nov 8, 2023
33 checks passed
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
Merged
@maximepvrt maximepvrt mentioned this pull request Nov 8, 2023
Merged
manniL pushed a commit that referenced this pull request Dec 11, 2023
@maximepvrt @danielroe
@DamianGlowala @manniL
chore: add homepage and repo directory to package.jsons (#24189)
30978c3 
Co-authored-by: Daniel Roe <[email protected]>
Co-authored-by: Damian Głowala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianGlowala DamianGlowala DamianGlowala left review comments

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximepvrt @danielroe @DamianGlowala