Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added nuxt3-leaflet module #693

Merged
merged 10 commits into from
Aug 3, 2023
Merged

feat: added nuxt3-leaflet module #693

merged 10 commits into from
Aug 3, 2023

Conversation

Gugustinette
Copy link
Contributor

@Gugustinette Gugustinette commented Jul 13, 2023

Resolves #682

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you remove one of these entries? And also, I'd recommend that you don't publish to npm referencing nuxt3. Maybe you could reach out to the person who published https://github.com/schlunsen/nuxt-leaflet (now archived) to ask if you could have the npm package name?

@Gugustinette
Copy link
Contributor Author

Hey @schlunsen , is there any way we can get the npm package name "nuxt-leaflet" ?

@schlunsen
Copy link

I'm on holiday and I would appreciate if you didn't contact my work in order to get your request done. Didn't see this message before and would gladly help, but I'm away from keyboard. This project isn't related to my work so again stop making noise in the wrong places. Saw your contact request on LinkedIn but ignored it since I don't know you.

@Gugustinette
Copy link
Contributor Author

Gugustinette commented Aug 1, 2023

Well I guess we'll stick with "nuxt3-leaflet" then

By the way I validated without the changes being pushed (I though this wouldn't let me validate if there was no changes 😭) The changes should now be on the branch

modules/nuxt3-leaflet.yml Outdated Show resolved Hide resolved
@danielroe danielroe merged commit 21f6d47 into nuxt:main Aug 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leaflet Module for Nuxt 3
4 participants