-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @eschricht/nuxt-color-mode module #1069
Conversation
Thank you for working on this module, have you considered contributing to the main one?
|
There has been multiple issues / pull requests on the main module to support both cookies and the Examples: But I'd happy to help out with the main module if you'd like! With full SSR support, I mean that it supports fetching system color scheme from the server (via the Also, the server cannot access browsers local storage so anything stored there will be resolved on the client only. Using cookies instead solves that issue as those are shared with the server. |
I just released the support for cookie storage! Are you happy to help on |
Sweet! I'll take a look at the I'll close this one |
@atinux Even with cookie storage it doesn't work with SSR. color mode gets updated only after app |
please open an issue there to discuss about it. it is hard to handle all cases so there are specific reasons why it works this way. like how do you handle pre-rendering or cached pages? |
@atinux I don't have any pre-render or caching if you mean that. by the way @Eschricht's module works without problem. |
Yes but when you make a module you need to think of all use cases, this is why I had to make compromises. BTW, how does it work for you |
@atinux I changed the preference from |
π Linked issue
resolves #1064
β Type of change
π Description
Added
@eschricht/nuxt-color-mode
module