Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ipx): set prerenderer config as well #784

Merged
merged 3 commits into from
Mar 29, 2023
Merged

fix(ipx): set prerenderer config as well #784

merged 3 commits into from
Mar 29, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #780

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The Nitro prerenderer does not share the same runtimeConfig instance so we can set it on _config.

Opening the PR as hotfix but we may also want to change behaviour in nitro or provide a hook to allow us to configure the prerenderer more specifically (even just another call of nitro:config would be ideal).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Mar 28, 2023
@danielroe danielroe requested a review from pi0 March 28, 2023 18:39
@danielroe danielroe self-assigned this Mar 28, 2023
@codesandbox
Copy link

codesandbox bot commented Mar 28, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Mar 28, 2023

βœ… Deploy Preview for nuxt-image-v1 canceled.

Name Link
πŸ”¨ Latest commit a92f48e
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-image-v1/deploys/64241277d4ba2b0007d6ad6f

@pi0
Copy link
Member

pi0 commented Mar 29, 2023

Calling nitro:config for proper fix seems good idea πŸ‘πŸΌ

src/ipx.ts Show resolved Hide resolved
@pi0 pi0 changed the title fix: set prerenderer config as well fix(ipx): set prerenderer config as well Mar 29, 2023
@pi0 pi0 merged commit 0aa03b6 into main Mar 29, 2023
@pi0 pi0 mentioned this pull request Mar 31, 2023
@ibrahim-990
Copy link

To fix this ERROR [nuxt] [request error] [unhandled] [500] The URL must be of scheme file.
on npm run generate.
I need to add the file (ipx.ts) ?
@pi0

@danielroe danielroe deleted the fix/prerenderer-config branch August 27, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR [nuxt] [request error] [unhandled] [500] Cannot read properties of undefined (reading 'dir')
3 participants