Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ipx): support runtime nuxt baseURL #778

Merged
merged 3 commits into from
Mar 22, 2023
Merged

fix(ipx): support runtime nuxt baseURL #778

merged 3 commits into from
Mar 22, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #665
#548

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds a new property nuxt.baseURL to global image options. Providers like IPX can take this into account when rendering their image URLs.

Some linting also took place in the types file - apologies, I couldn't resist, but I separated out the commit.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working ipx labels Mar 21, 2023
@danielroe danielroe requested a review from pi0 March 21, 2023 12:28
@danielroe danielroe self-assigned this Mar 21, 2023
@netlify
Copy link

netlify bot commented Mar 21, 2023

βœ… Deploy Preview for nuxt-image-v1 canceled.

Name Link
πŸ”¨ Latest commit 36cae70
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-image-v1/deploys/6419a389d1420d0007b8e021

@pi0 pi0 merged commit 1a5eea1 into main Mar 22, 2023
@danielroe danielroe deleted the fix/ipx-baseurl branch March 22, 2023 17:18
@pi0 pi0 mentioned this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ipx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to update [ipx.BASE_URL] in nuxt/image config
2 participants