Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): cloudflare #359

Merged
merged 13 commits into from
Jun 21, 2022
Merged

Conversation

shadow81627
Copy link
Contributor

@shadow81627
Copy link
Contributor Author

I don't have access to a cloudflare domain that has image resize enabled so I am unable to complete tests.

@shadow81627
Copy link
Contributor Author

I also need to create a pull request to update the cloudflare image docs to add @nuxt/image as an integration.

@pi0
Copy link
Member

pi0 commented Jul 8, 2021

Thanks for the PR @shadow81627 <3 I will contact the CF team to see if we can have a testing domain for the playground.

In the meantime do you mind checking failing tests?

@pi0
Copy link
Member

pi0 commented Jul 8, 2021

Sample baseURL for playground (thanks to @xtuc) :

@shadow81627
Copy link
Contributor Author

Sample baseURL for playground (thanks to @xtuc) :

I don't think I will have time to update the PR today. I will try and do it tomorrow.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2021

Codecov Report

Merging #359 (42bf0be) into main (8601e61) will decrease coverage by 58.59%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #359       +/-   ##
==========================================
- Coverage   58.59%   0.00%   -58.60%     
==========================================
  Files          33      32        -1     
  Lines         698     632       -66     
  Branches      231     212       -19     
==========================================
- Hits          409       0      -409     
- Misses        282     627      +345     
+ Partials        7       5        -2     
Impacted Files Coverage Δ
src/provider.ts 0.00% <ø> (-74.29%) ⬇️
src/runtime/providers/cloudflare.ts 0.00% <0.00%> (ø)
src/runtime/providers/ipx.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/glide.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/imgix.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/fastly.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/gumlet.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/static.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/unsplash.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/contentful.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8601e61...42bf0be. Read the comment docs.

@pi0 pi0 added the provider label Jan 13, 2022
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@pi0 pi0 merged commit e503679 into nuxt:main Jun 21, 2022
pi0 added a commit that referenced this pull request Jun 21, 2022
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants