-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudinary): support reading project from absolute url #1361
Conversation
Would you be able to add an example to the test suite? 🙏 |
@danielroe - I have added an example to the test suite in cc86997 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1361 +/- ##
==========================================
+ Coverage 61.95% 63.20% +1.25%
==========================================
Files 79 79
Lines 3609 3615 +6
Branches 392 407 +15
==========================================
+ Hits 2236 2285 +49
+ Misses 1343 1301 -42
+ Partials 30 29 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you ❤️
Resolves #1376
Adds the ability for a full cloudinary url to be used as
src
instead of relying onbaseURL
to construct the image url.For example:
should use
https://res.cloudinary.com/example/image/upload
as thebaseURL
, regardless of whatbaseURL
is configured as.This is needed for apps that receive a full cloudinary url from the backend which may be responsible for determining the specific cloud and base url.
See discussion in Discord thread: https://discord.com/channels/473401852243869706/1238298456540577802