Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudinary): support reading project from absolute url #1361

Merged
merged 15 commits into from
Aug 29, 2024

Conversation

markbrouch
Copy link
Contributor

@markbrouch markbrouch commented May 10, 2024

Resolves #1376

Adds the ability for a full cloudinary url to be used as src instead of relying on baseURL to construct the image url.

For example:

<NuxtImg src="https://res.cloudinary.com/example/image/upload/example.jpg" />

should use https://res.cloudinary.com/example/image/upload as the baseURL, regardless of what baseURL is configured as.

This is needed for apps that receive a full cloudinary url from the backend which may be responsible for determining the specific cloud and base url.

See discussion in Discord thread: https://discord.com/channels/473401852243869706/1238298456540577802

@danielroe
Copy link
Member

Would you be able to add an example to the test suite? 🙏

@markbrouch
Copy link
Contributor Author

@danielroe - I have added an example to the test suite in cc86997

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.20%. Comparing base (92a6eee) to head (c7ceeed).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1361      +/-   ##
==========================================
+ Coverage   61.95%   63.20%   +1.25%     
==========================================
  Files          79       79              
  Lines        3609     3615       +6     
  Branches      392      407      +15     
==========================================
+ Hits         2236     2285      +49     
+ Misses       1343     1301      -42     
+ Partials       30       29       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@danielroe danielroe changed the title feat: support cloudinary urls as src feat(cloudinary): support reading project from absolute url Aug 29, 2024
@danielroe danielroe merged commit 96101b6 into nuxt:main Aug 29, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Aug 29, 2024
@markbrouch markbrouch deleted the cloudinary-url branch September 3, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Absolute Cloudinary URLs do not work
3 participants