fix: handle undefined
or empty image source values
#1300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #1299
I have been thinking about the best solution for this issue. Typescript says by design that the src prop is string | undefined so we either need to narrow that down or allow it?
Vue by design always adds undefined type as far as I could see. When I removed the throw error it works more as expected and with the reuired property on the src prop I get a Vue warning that it is not set which is nice.
However when I set:
:src="undefined"
I get a Vue warning the the type for the src prop is incorrect.Is it better to match the typescript types (and it quite follows the normal behaviour or have it generate a Vue prop required warning with the above downside?