Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support domains option with Netlify Image CDN #1287

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

ascorbic
Copy link
Contributor

Adds support for configuring remote images in Netlify Image CDN. Previously this required manual configuration in the netlify.toml. With this PR, the provider sets the value automatically based on the image.domains option.

Depends on nitrojs/nitro#2264

Copy link

nuxt-studio bot commented Mar 15, 2024

Live Preview ready!

Name Edit Preview Latest Commit
Image Edit on Studio ↗︎ View Live Preview 97f96d6

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 66.96%. Comparing base (8701991) to head (8907444).
Report is 33 commits behind head on main.

Files Patch % Lines
src/provider.ts 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1287      +/-   ##
==========================================
- Coverage   68.20%   66.96%   -1.24%     
==========================================
  Files          76       79       +3     
  Lines        4299     4501     +202     
  Branches      397      404       +7     
==========================================
+ Hits         2932     3014      +82     
- Misses       1339     1458     +119     
- Partials       28       29       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just waiting for Nitro PR to merge.

@ascorbic
Copy link
Contributor Author

@danielroe the Nitro PR is now in!

@danielroe
Copy link
Member

Fantastic! I’ll just confirm that domains are always normalised to without protocol and then we should be good to go…

@danielroe danielroe merged commit b3bde17 into nuxt:main Mar 27, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants