Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hygraph provider #1152

Merged
merged 7 commits into from
Dec 17, 2023
Merged

feat: add hygraph provider #1152

merged 7 commits into from
Dec 17, 2023

Conversation

timbenniks
Copy link
Contributor

To my surprise, there was no Nuxt/Image provider for Hygraph yet!

Copy link

nuxt-studio bot commented Dec 14, 2023

Live Preview ready!

Name Edit Preview Latest Commit
Image Edit on Studio ↗︎ View Live Preview e523599

@danielroe danielroe changed the title feat: Added Hygraph provider feat: add hygraph provider Dec 14, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (2dee537) 70.75% compared to head (5e25eca) 69.67%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/runtime/providers/hygraph.ts 0.00% 61 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
- Coverage   70.75%   69.67%   -1.08%     
==========================================
  Files          71       72       +1     
  Lines        4065     4128      +63     
  Branches      384      385       +1     
==========================================
  Hits         2876     2876              
- Misses       1165     1226      +61     
- Partials       24       26       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timbenniks
Copy link
Contributor Author

@danielroe I also added an undocumented-by-hygraph quality setting to the provider. Tests still pass.

@danielroe danielroe merged commit e51b740 into nuxt:main Dec 17, 2023
2 checks passed
riddla pushed a commit to tricks-gmbh/nuxt-image that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants