Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sirv provider #1066

Merged
merged 2 commits into from
Oct 22, 2023
Merged

feat: add sirv provider #1066

merged 2 commits into from
Oct 22, 2023

Conversation

IgorVaryvoda
Copy link
Contributor

@IgorVaryvoda IgorVaryvoda commented Oct 20, 2023

This PR adds support for Sirv image provider

@nuxt-studio
Copy link

nuxt-studio bot commented Oct 20, 2023

Live Preview ready!

Name Edit Preview Latest Commit
Image Edit on Studio ↗︎ View Live Preview 8da8f38

@danielroe danielroe added enhancement New feature or request provider labels Oct 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58c5139) 89.66% compared to head (d876277) 90.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
+ Coverage   89.66%   90.04%   +0.37%     
==========================================
  Files          44       45       +1     
  Lines        2933     3044     +111     
  Branches      330      335       +5     
==========================================
+ Hits         2630     2741     +111     
- Misses        301      302       +1     
+ Partials        2        1       -1     
Files Coverage Δ
src/provider.ts 97.54% <100.00%> (+0.02%) ⬆️
src/runtime/providers/sirv.ts 100.00% <100.00%> (ø)
src/types/module.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great ❤️

@danielroe danielroe changed the title feat: sirv provider feat: add sirv provider Oct 22, 2023
@danielroe danielroe merged commit 4360928 into nuxt:main Oct 22, 2023
2 checks passed
riddla pushed a commit to tricks-gmbh/nuxt-image that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants