This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): use shared state for asyncData #7055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
nuxt/nuxt#13910 #5078 #5738
β Type of change
π Description
With the initial implementation of
useAyncData
, we were using a shared promise to avoid running two asyncData promises with the same key at the same time but the fetching state and data was not shared. It makes problems if someone tries to make a higher-order composable that returns a new instance of asyncData with the same key.This PR resolves it using a shared
_asyncData
map in nuxtApp interface also adding tests from #5738 by @OhB00.Remarks:
We probably can iterate over this. Normally each useAsyncData should be unique based on its key and a factory pattern shall be introduced for
createAsyncData
andcreateFetch
(discussion: nuxt/nuxt#14736)I will follow up with more PRs to have proper changelog.
π Checklist