Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat!(schema): enable external vue by default #6868

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#13632

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This enables external vue by default on edge releases. Instead, it can be disabled by setting experimental.externalVue to false. Before RC, we can then remove the flag entirely.

I have tested on a few projects (small + large projects, no monorepo, a module's playground) with no issues, but some issues might be expected, particularly in complex projects with multiple vue component libraries. Feedback is particularly welcome. Please feel free to tag me in a new issue if you encounter any problems.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the enhancement New feature or request label Aug 23, 2022
@danielroe danielroe requested a review from pi0 August 23, 2022 11:07
@danielroe danielroe self-assigned this Aug 23, 2022
@netlify
Copy link

netlify bot commented Aug 23, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 27c65c9
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6304b4e7b32225000831f9c5

@pi0 pi0 changed the title feat(schema): enable external vue by default feat!(schema): enable external vue by default Aug 23, 2022
@pi0 pi0 merged commit 51dc736 into main Aug 23, 2022
@pi0 pi0 deleted the fix/enable-external-vue-by-default branch August 23, 2022 11:35
@pi0 pi0 mentioned this pull request Aug 26, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants