This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): resolve vue/server-renderer and vue/compiler-sfc
#4488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt3-docs canceled.
|
This was referenced Apr 21, 2022
pi0
changed the title
vue/server-renderer and vue/compiler-sfcvue/server-renderer and vue/compiler-sfc
pi0
reviewed
Apr 22, 2022
pi0
reviewed
Apr 22, 2022
| @@ -64,8 +64,8 @@ export async function initNitro (nuxt: Nuxt) { | |||
| }, | |||
| alias: { | |||
| // TODO: #590 | |||
| 'vue/server-renderer': 'vue/server-renderer', | |||
| 'vue/compiler-sfc': 'vue/compiler-sfc', | |||
| 'vue/server-renderer': await resolvePath('vue/server-renderer', { conditions: ['import'] }), | |||
There was a problem hiding this comment.
I guess mlly resolver should apply import condition by default following module resolution. But we can path url (as node modules dir search path to it so that if a newer version is specified by users will be picked, same as resolvePath in kit)
|
@antfu Can you please check if we still need this with last version of nitro with node_modules fix? |
|
I can confirm it's fixed by upgrading nitropack to v0.3.7. Awesome! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Partially fix nuxt/nuxt#13700
It will be fixed by the combination of this PR and nitrojs/nitro#136
❓ Type of change
📚 Description
📝 Checklist