This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
feat(nitro)!: support overriding runtime config at a second level #3007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Type of change
π Description
Currently we can only override at the top level of runtime config. This now allows for overriding at a second (nested) level, for example, for modules which want to allow runtime configuration. At the same time, we also normalise to upper-snake-case (
baseURL
->BASE_URL
)Consider this example:
Notes
Note that we have special handling for app config - perhaps we can abandon this and default to (e.g.) APP_CDN_URL instead of NUXT_APP_CDN_URL?
framework/packages/nitro/src/runtime/app/config.ts
Lines 24 to 28 in a971aab
If we're happy with this approach, I will update the documentation.π Migration
baseURL
->BASE_URL
).π Checklist