Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): don't match other endpoints _beginning_ with _nuxt #10121

Closed
wants to merge 2 commits into from
Closed

fix(vite): don't match other endpoints _beginning_ with _nuxt #10121

wants to merge 2 commits into from

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When adding a vite middleware starting with /_nuxt we were wrongly skipping the vite transform. This PR adds a trailing slash to confirm.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Jan 16, 2023
@codesandbox
Copy link

codesandbox bot commented Jan 16, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe
Copy link
Member Author

closing ~> #10120

@danielroe danielroe closed this Jan 16, 2023
@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe deleted the fix/middleware-test branch January 19, 2023 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@antfu antfu

@danielroe danielroe

Labels
3.x bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing vite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @antfu