Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use plugin:vue/vue3-recommended for Nuxt 3 #217

Closed
wants to merge 1 commit into from
Closed

feat: use plugin:vue/vue3-recommended for Nuxt 3 #217

wants to merge 1 commit into from

Conversation

DamianGlowala
Copy link
Member

@DamianGlowala DamianGlowala commented Jun 20, 2022

Closes #216

@pi0
Copy link
Member

pi0 commented Jun 21, 2022

Thanks for the pull request. I'm thinking maybe we can split the preset into main + vue2 + vue3? If we do this change, all of the current Nuxt 2 users will be stuck to an older version of eslint-config, and Nuxt 2 is still the "stable" release channel. /cc @clarkdo WDYT?

@DamianGlowala
Copy link
Member Author

That's exactly what my concern was when creating this PR! Hmm is there a smart way to detect which version of Nuxt is being used? ;) That would solve an issue quite easily.

@pi0
Copy link
Member

pi0 commented Jun 21, 2022

Since we are in a JS context, we might try to require nuxt/package.json and infer the version maybe? (It should be using createRequire and cwd btw. since eslint preset is deep in node-modules)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuxt 3: plugin:vue/vue3-recommended instead of plugin:vue/recommended
2 participants