Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(state-editor): update deepSync function #713

Merged
merged 2 commits into from
Aug 26, 2024
Merged

fix(state-editor): update deepSync function #713

merged 2 commits into from
Aug 26, 2024

Conversation

arashsheyda
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

this should fix #710

Note: I didn't use this tab much so I wasn't sure about the functionality, right now if we edit a value in JsonEditor (for example something in Public Runtime Config), the prop.state is not getting updated. is that intended?

Copy link

cloudflare-workers-and-pages bot commented Aug 23, 2024

Deploying nuxt-devtools with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: 2f8d603
Status:Β βœ…Β  Deploy successful!
Preview URL: https://2102b525.nuxt-devtools.pages.dev
Branch Preview URL: https://fix-710.nuxt-devtools.pages.dev

View logs

@arashsheyda arashsheyda changed the title fix(state-editor): update deepSync function to handle state prop fix(state-editor): update deepSync function Aug 23, 2024
@antfu antfu merged commit a7b9efb into main Aug 26, 2024
3 checks passed
@antfu antfu deleted the fix/710 branch August 26, 2024 17:59
@antfu
Copy link
Member

antfu commented Aug 26, 2024

Yeah, I broke it in a few releases back πŸ˜… I need to have a closer look to fix it.

@arashsheyda
Copy link
Member Author

great, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Client side navigation while the payload tab is open causes errors in the console
2 participants