Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add storage tab #100

Merged
merged 19 commits into from
Feb 28, 2023
Merged

feat: add storage tab #100

merged 19 commits into from
Feb 28, 2023

Conversation

atinux
Copy link
Member

@atinux atinux commented Feb 25, 2023

Video is better to see:

CleanShot.2023-02-25.at.19.07.01.mp4

I would like to test it on edge first on different projects in order to improve it before having it in 0.3.0.

@atinux
Copy link
Member Author

atinux commented Feb 25, 2023

The next steps for me will be to get more informations about each prefix (mounts) and group them so we have more informations about each storage namespace (cc @pi0 )

@atinux
Copy link
Member Author

atinux commented Feb 25, 2023

Happy to get some help on why the CI fails 🤔

CleanShot 2023-02-25 at 19 15 21@2x

@antfu
Copy link
Member

antfu commented Feb 25, 2023

It's a unbuild bug I think. Adding unstroage to external in build.config.ts should fix it.

@atinux
Copy link
Member Author

atinux commented Feb 26, 2023

Nice one @antfu

Should be good now.

Copy link
Member Author

atinux commented Feb 26, 2023

Wondering if we should add an option for now like devtools.experimental.storage: true to enable this tab (and other in the future to beta test), wdyt?

@pi0
Copy link
Member

pi0 commented Feb 27, 2023

Really nice work 💯

The next steps for me will be to get more informations about each prefix (mounts) and group them so we have more informations about each storage namespace (cc @pi0 )

I was going to link it before reading your comment :D @farnabaz already suggested this. tracker unjs/unstorage#53. (in the meantime you can also use Object.keys(nitro.options.storage) to draft something.

It's a unbuild bug I think. Adding unstroage to external in build.config.ts should fix it.

Nice workaround by adding to externals. BTW it is not a bug of unbuild or rollup. Since unstorage is not a dependency of the package it is building (but rather an implicit dependency installed via Nuxt and Nitro). In this case rollup tries to bundle the types by default behavior and we need to instruct it not to.

@atinux
Copy link
Member Author

atinux commented Feb 27, 2023

(in the meantime you can also use Object.keys(nitro.options.storage) to draft something.

Will it also have the devStorage merged into it?

@pi0
Copy link
Member

pi0 commented Feb 27, 2023

Will it also have the devStorage merged into it?

We need to check both indeed.

Copy link
Member Author

atinux commented Feb 27, 2023

Went for this settings to enable experimental features:
https://volta.s3.fr-par.scw.cloud/Clean_Shot_2023_02_27_at_18_20_40_862dabac5a.mp4

So we can use

definePageMeta({
  icon: 'carbon-data-base',
  title: 'Storage',
  experimental: true,
})

Copy link
Member Author

atinux commented Feb 27, 2023

Will push later tonight once I am done supporting the different mounts

@nuxt-studio
Copy link

nuxt-studio bot commented Feb 28, 2023

Live Preview ready!

Name Edit Preview Latest Commit
devtools Edit on Studio ↗︎ View Live Preview 9c406ce

@antfu antfu merged commit c153313 into main Feb 28, 2023
@antfu antfu deleted the feat/storage branch February 28, 2023 19:01
@antfu antfu restored the feat/storage branch February 28, 2023 19:13
@antfu antfu deleted the feat/storage branch February 28, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants