feat(module): Force new dependencies to be devDependencies (if it's in a specific list) #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
reviewed
Oct 22, 2024
| @@ -15,6 +15,12 @@ import { | |||
| } from './_utils' | |||
| import type { NuxtModule } from './_utils' | |||
|
|
|||
| // Maybe we can import the list from somewhere, but idk | |||
There was a problem hiding this comment.
in general I would think modules should match nuxt rather than forcing modules to development mode. they will be required in the same environment as nuxt (i.e the build environment).
if anything we could support a flag to allow the user to choose (--dev).
There was a problem hiding this comment.
(we could also add this list to the module registry meta btw)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#454
❓ Type of change
📚 Description
This PR makes some changes to the module add directive: it detects a specific list of npm dependencies when adding them, and if the npm dependency to be installed is in that list, it will be installed as a development dependency.
While Nuxt will extract what is needed into the final build product, dependencies like
@nuxt/eslintshould not be installed as “dependencies” but as “devDependencies” in the original meaning of dependencies and devDependencies. Hence the PR.It's not a good practice to write a dead list inside the module add function, but I haven't come up with a perfect way to do it at this stage either.