Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow overriding internal dev server port via _PORT #165

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 11, 2023

The internal _PORT was introduced in #94 in order to make running in test env easier and used in @nuxt/test-utils

With #53 rewrites, it is unnecessary for test utils to depend on _dev as main dev commands smartly disables forked mode for testing environment but this fix avoid a regression (i hope for a while until all migrate to latest test-utils and we land migration back to main dev)

@pi0 pi0 requested a review from danielroe September 11, 2023 12:17
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this ❤️

@pi0 pi0 merged commit cf0fe6d into main Sep 11, 2023
2 checks passed
@pi0 pi0 deleted the fix/internal-dev-port branch September 11, 2023 12:21
@pi0 pi0 changed the title fix: allow overriding internal dev server error via _PORT fix: allow overriding internal dev server port via _PORT Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants