fix: polyfill event for useRequestEvent when nitro is disabled
#999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyYolkin
changed the title
useRequestEvent returns H3Event with disabled nitrouseRequestEvent returns H3Event with disabled nitro
danielroe
reviewed
Dec 2, 2023
pi0
approved these changes
Dec 13, 2023
| // Check if we created H3 event manually before | ||
| if (nuxtApp.ssrContext?._event) { return nuxtApp.ssrContext._event } | ||
| // Create H3 event https://github.com/nuxt/bridge/pull/999#discussion_r1413049422 | ||
| nuxtApp.ssrContext._event = createEvent(nuxtApp.ssrContext?.req, nuxtApp.ssrContext?.res) |
There was a problem hiding this comment.
Mind you this is a very fragile low-level method and behavior can be broken in future releases but considering that it is acceptable for edge-case usage in bridge, looks good workaround...
danielroe
changed the title
useRequestEvent returns H3Event with disabled nitrouseRequestEvent when nitro is disabled
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes #998
This PR forces
useRequestEventfunction to create h3-compatible event (viacreateEventutility from h3). So, when nitro disabled, useRequestEvent will return constructed event fromnuxtApp.ssrContext.reqandnuxtApp.ssrContext.res❓ Type of change
📚 Description
📝 Checklist