-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: migrate to vite 3 #480
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
force-pushed
the
feat/vite-3
branch
2 times, most recently
from
August 17, 2022 14:47
a930229
to
2eb1466
Compare
danielroe
force-pushed
the
feat/vite-3
branch
from
September 23, 2022 20:19
d73c07d
to
50e58f2
Compare
@pi0 - note stub fix for now - please do let me know if you have a better idea. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves #492
β Type of change
π Description
This PR upgrades Bridge to Vite 3.
There are quite a few fixes/refactors to note, including some other vite fixes in Nuxt 3 that we're hereby porting back to Bridge. But particularly worth observing:
We remove the workaround where we move build output files around, instead modifying chunk names.
We remove our runtime URL implementation, using new Vite support from feat: experimental.buildAdvancedBaseOptionsΒ vitejs/vite#8450.
We'll track the development of this feature quite closely as it moves from experimental into the mainstream, but it will not break in a minor version so the current version constraint is safe.
π Migration
Vite 3 is a major release with its own breaking changes. Users should read through the migration guide and make any updates necessary. (Other libraries may also have to be updated to work with Vite 3.)
There are no Nuxt-specific changes that users will need to make.
π Checklist