Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip node for which definePageMeta does not exist #1223

Merged
merged 1 commit into from
May 24, 2024

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented May 24, 2024

πŸ”— Linked issue

Fixes: #1222

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I expected to skip setup node that did not have definePageMeta, but I was not able to skip them, so I would like to fix that.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe merged commit 8d7c5f0 into main May 24, 2024
61 checks passed
@danielroe danielroe deleted the fix/skip-does-not-exist-page-meta branch May 24, 2024 20:26
@github-actions github-actions bot mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

definePageMeta causes a compile error if there is an object with a property name setup.
2 participants