-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retries to Supabase client #382
Merged
Merged
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
34a9432
feat: add retries to Supabase client
felixgabler 2d442d7
refactor: fix lint issue
felixgabler e9441db
chore: regenerate lock file
felixgabler ebe886b
chore: update dependencies
felixgabler 412f4ed
feat: do not retry if aborted
felixgabler ff66b3f
fix: set realtime auth token manually
felixgabler 7c547cd
chore: update dependencies
felixgabler 3000bf5
chore: update dependencies
felixgabler 1302ea6
Merge branch 'main' into pr/382
larbish b254b6e
refactor: remove custom realtime token setting
felixgabler 1aa4419
Merge branch 'fg/retry_fetch' of https://github.com/felixgabler/supab…
felixgabler 5442a5f
chore(deps): remove prettier (#403)
th1m0 78d1d86
fix(types): add explicit types for composables & remove `baseUrl` fro…
th1m0 f09d6e3
fix(types): nullable composable types (#407)
th1m0 7f9626e
Merge branch 'main' into pr/382
larbish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
export async function fetchWithRetry(req: RequestInfo | URL, init?: RequestInit): Promise<Response> { | ||
const retries = 3 | ||
for (let attempt = 1; attempt <= retries; attempt++) { | ||
try { | ||
return await fetch(req, init) | ||
} | ||
catch (error) { | ||
// Don't retry if it's an abort | ||
if (init?.signal?.aborted) { | ||
throw error | ||
} | ||
if (attempt === retries) { | ||
console.error(`Error fetching request ${req}`, error, init) | ||
throw error | ||
} | ||
console.warn(`Retrying fetch attempt ${attempt + 1} for request: ${req}`) | ||
} | ||
} | ||
throw new Error('Unreachable code') | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this line for? I can't find any documentation about this
realtime.setAuth
method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this slipped in there because there is a realtime bug that I am debugging with the Supabase team where the auth token does not correctly propagate to realtime. Will take it out for now