fix(storybook): normalize win32 paths for storybook globs #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Changes
Added upath to normalize paths to POSIX specs (same strategy as here nuxt/nuxt#7796) and used it when resolving glob patterns for
stories
array.Explanation
With
2.1.0
, generated.nuxt-storybook/storybook/main.js
looks like this on Windows:The above is not a valid glob pattern and will lead to a fatal error while running Storybook. Since glob patterns are expected to use the POSIX separator this use upath to normalize them and will fix globs array:
Let me know if you need further explanation, if you want me to fill a proper issue, or prefer another implementation 🙂
Cheers~
ps: I also checked/tested a bit for similar errors but found none, not sure what could be a more efficient strategy at ensuring things are win32 friendly in the long run 🤔