Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nuxt content check at module setup #170

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: nuxt content check at module setup #170

merged 1 commit into from
Dec 5, 2024

Conversation

sandros94
Copy link
Contributor

🔗 Linked issue

Resolves #169

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Fixed the initial state for useNuxtContent inside module's setup.

@sandros94
Copy link
Contributor Author

I've also noticed that the ts comment could be removed at

robots/src/module.ts

Lines 426 to 427 in 16bed48

// @ts-expect-error untyped
cacheControl: config.cacheControl,

Since config.cacheControl looks to be correctly typed

@harlan-zw
Copy link
Contributor

Thank you!

@harlan-zw harlan-zw merged commit 00c4f8a into nuxt-modules:main Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: nuxt content check at module setup
2 participants
@sandros94 @harlan-zw