Fix types for runtime/plugin.ts not being created correctly #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
At some point, I think following #214, the following error started to happen following a
pnpm build:module
:This can be seen in CI pipeline for the latest release https://github.com/nuxt-modules/prismic/actions/runs/10647703821
This results in the generated
dist/runtime/plugin.client.d.ts
anddist/runtime/plugin.d.ts
being empty.This causes an error in a wider nuxt application as the following lines of code have the
any
typeThis PR fixes this error. Note - I don't have much experience with Nuxt plugins, I'm not sure if there are any consequences to importing from
nuxt/app
rather than#imports
? Anyhow this results in the types being created correctly (alternative solution is to do aas Plugin<{ prismic: PrismicPlugin}>
castChecklist: