Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow factory function for customClient #219

Merged
merged 3 commits into from
Aug 31, 2024
Merged

feat: allow factory function for customClient #219

merged 3 commits into from
Aug 31, 2024

Conversation

huang-julien
Copy link
Contributor

@huang-julien huang-julien commented Aug 30, 2024 •
edited
Loading

Types of changes

resolve #218

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Hey 👋

This PR allows users to provide a factory function for the customCLient

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

@netlify Netlify
Copy link

netlify bot commented Aug 30, 2024

👷 Deploy request for prismic-module pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 81d1ff1

lihbr
lihbr approved these changes Aug 31, 2024
View reviewed changes
Copy link
Collaborator

@lihbr lihbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful ❤️

@lihbr lihbr merged commit bd7d02d into nuxt-modules:master Aug 31, 2024
@lihbr
Copy link
Collaborator

lihbr commented Aug 31, 2024

Released in 3.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihbr lihbr lihbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to provide a factory function for the custom client
2 participants
@huang-julien @lihbr