Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle nuxt.router.base options when resolving previews #140

Merged
merged 1 commit into from
May 20, 2021

Conversation

andypattenden
Copy link
Contributor

@andypattenden andypattenden commented May 20, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

Prefixes url used by the preview function for static sites with the router.base (with any trailing slash removed) set in nuxt.config.js.

Resolves: #139

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • All new and existing tests are passing.

Adds the base path to preview urls for static sites.
@netlify
Copy link

netlify bot commented May 20, 2021

Deploy request for prismic-module pending review.

Review with commit e14029e

https://app.netlify.com/sites/prismic-module/deploys

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #140 (e14029e) into master (0205bcc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #140   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           51        51           
=========================================
  Hits            51        51           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0205bcc...e14029e. Read the comment docs.

@lihbr lihbr changed the title Add the base path to preview urls for static sites fix: handle nuxt.router.base options when resolving previews May 20, 2021
@lihbr lihbr merged commit 63d3fee into nuxt-modules:master May 20, 2021
@lihbr
Copy link
Collaborator

lihbr commented May 20, 2021

Published in v1.3.1: https://github.com/nuxt-community/prismic-module/blob/master/CHANGELOG.md#131-2021-05-20

Thanks! 💚

@andypattenden andypattenden deleted the fix/preview-url-base branch January 7, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static site Prismic page previews don't work when base is set
2 participants