Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inline code highlighting #39

Merged
merged 8 commits into from
Sep 19, 2023
Merged

fix: inline code highlighting #39

merged 8 commits into from
Sep 19, 2023

Conversation

nobkd
Copy link
Contributor

@nobkd nobkd commented Sep 17, 2023

Issue/Discussion

fixes nuxt/content#2316

Changes

Also parse code tag if it has a language prop.

Important
We probably have to add back lang instead of supporting only language, right?
Otherwise, this breaking change has to be mentioned (and changed everywhere in the docs, etc.).

What do you think about that?

Edit: added back support for lang property.


Also, for me, a general PR template would be helpful :)

@ijkml
Copy link

ijkml commented Sep 17, 2023

Hi @nobkd, please could you also take a look at line highlighting in code blocks https://stackblitz.com/edit/github-ybzbbs?file=content%2Findex.md

Thanks.

@nobkd
Copy link
Contributor Author

nobkd commented Sep 17, 2023

@ijkml this has already been fixed but isn't released yet :)
See issue #19 with PR #21 and additional commits 7cbe123 and c5633c3.

@ijkml
Copy link

ijkml commented Sep 17, 2023

Thank you, @nobkd, and sorry for hijacking your sunday 😅.

@farnabaz
Copy link
Collaborator

Thanks @nobkd
Do you mind adding a test for it?

@nobkd
Copy link
Contributor Author

nobkd commented Sep 18, 2023

I'll try.

@nobkd nobkd requested a review from farnabaz September 18, 2023 17:34
@nobkd
Copy link
Contributor Author

nobkd commented Sep 18, 2023

I hope the tests are alright like that, not sure how to do it better.
Let me know if you have suggestions / tips.

Copy link
Collaborator

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and tests ❤️

@farnabaz farnabaz merged commit 484d7d9 into nuxt-modules:main Sep 19, 2023
2 checks passed
@nobkd nobkd deleted the fix/inline-code-highlighting branch September 19, 2023 13:03
@farnabaz farnabaz mentioned this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants