Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warn when using SEO features without baseUrl #3145

Conversation

BobbieGoede
Copy link
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #2941

Adds a warning when using SEO features without setting baseUrl, may change this to throw an error instead before creating release candidate.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Sep 30, 2024
Copy link

pkg-pr-new bot commented Sep 30, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@nuxtjs/i18n@3145

commit: 5089f83

Copy link

pkg-pr-new bot commented Sep 30, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@nuxtjs/i18n@3145

commit: f1dafc2

@BobbieGoede BobbieGoede changed the title fix: warn if seo features are used without baseUrl fix: warn when using SEO features without baseUrl Sep 30, 2024
@BobbieGoede BobbieGoede merged commit 35b45a9 into nuxt-modules:main Sep 30, 2024
9 checks passed
@BobbieGoede BobbieGoede deleted the fix/warn-seo-features-without-base-url branch September 30, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when using SEO features without configuring baseUrl
1 participant