fix: generated module augmentation should use @intlify/core-base
#3034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
After some more testing it seems necessary to augment
@intlify/core-base
, as the types will not be inferred when using@intlify/core
. I suppose this makes as this is where the other packages import from? π€ I will open a PR to correct the JSDoc/comment invue-i18n
as well (intlify/vue-i18n#1898).This behavior differs from the types in the playground within this repository, in which case augmenting
@intlify/core
works as well, I'm not entirely sure why that is.π Checklist