Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generated module augmentation should use @intlify/core-base #3034

Conversation

BobbieGoede
Copy link
Collaborator

@BobbieGoede BobbieGoede commented Jul 18, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

After some more testing it seems necessary to augment @intlify/core-base, as the types will not be inferred when using @intlify/core. I suppose this makes as this is where the other packages import from? πŸ€” I will open a PR to correct the JSDoc/comment in vue-i18n as well (intlify/vue-i18n#1898).

This behavior differs from the types in the playground within this repository, in which case augmenting @intlify/core works as well, I'm not entirely sure why that is.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@kazupon
Copy link
Collaborator

kazupon commented Jul 19, 2024

I suppose this makes as this is where the other packages import from?

Yes!
GeneratedTypeConfig is declared at @intlify/core-base, so we need to argument from it.

@kazupon kazupon merged commit e2c58c6 into nuxt-modules:main Jul 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants