Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: lazy load i18n files" #2219

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

kazupon
Copy link
Collaborator

@kazupon kazupon commented Jul 10, 2023

Reverts #2193

@kazupon kazupon merged commit 8d65ac4 into next Jul 10, 2023
@kazupon kazupon deleted the revert-2193-fix-lazy-load-files branch July 10, 2023 07:36
@userquin
Copy link
Collaborator

@kazupon why do you revert also the lazy commit ?

@kazupon
Copy link
Collaborator Author

kazupon commented Jul 12, 2023

Lazy load does not works.
You can try it in the nuxt-i18n playground.

@userquin
Copy link
Collaborator

It is working in my vuetify nuxt module with single and multiple files per locale:
https://github.com/userquin/vuetify-nuxt-module

I Will check it later in my local.

@userquin
Copy link
Collaborator

userquin commented Jul 13, 2023

@kazupon the i18n playground seems to be working with a few changes from #2219 , the playground should change the lang when clicking on the links no?

imagen

imagen

@userquin
Copy link
Collaborator

userquin commented Jul 13, 2023

EDIT: it seems something wrong with the imports, check the screenshot here: #2212 (comment)

About the null entry, in the playground here also missing some entry/request, the virtual entry is not there.

I guess it is something in Nuxt, Nuxt DevTools inspector isn't able to intercept virtual modules when virtual module using default Vite name convention (prefixing ids with \0).

I'll try to change the resolved virtual ids here and check if it is working...

imagen

@kazupon
Copy link
Collaborator Author

kazupon commented Jul 14, 2023

Thanks!
I look forward to PR from you :)

DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants