fix: registerModule hook not working for js/ts format resources #2188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#2141
β Type of change
π Description
It seems that only locales within the project
langDir
were being resolved in the following line: https://github.com/nuxt-modules/i18n/blob/next/src/utils.ts#L62C1-L62C92This results in locales added via the
i18n:registerModule
hook and possibly layers too would not get atype
ortypes
assigned to it, which as far as I understand is required for js/ts format locales (I'm still catching up with the changes made in the last few months π ).Note that my changes removes the file extension check/filter in the resolve function, I could add a basic matcher to ensure each file has the correct extension if needed.
π Checklist