Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Compare also decoded Url with a route #1816

Merged
merged 1 commit into from
Jan 24, 2023
Merged

fix: Compare also decoded Url with a route #1816

merged 1 commit into from
Jan 24, 2023

Conversation

szwenni
Copy link
Contributor

@szwenni szwenni commented Jan 24, 2023

🔗 Linked issue

#1792

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds an additional check for the route to check if a redirect is needed Before a encoded url part like an 'ä' or a whitespace would have created a endless loop.
This fixes #1792

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

fix: Compare also decoded Url with a route
6e26246 
This adds an additional check for the route to check if a redirect is needed.
Before a encoded url part like an 'ä' or a whitespace would have created a endless loop.
kazupon
kazupon approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to contribution!
Look good for me!
Thank you so much!

@kazupon kazupon merged commit 920a4fe into nuxt-modules:next Jan 24, 2023
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
@szwenni
fix: Compare also decoded Url with a route (nuxt-modules#1816)
69f9bb7 
This adds an additional check for the route to check if a redirect is needed.
Before a encoded url part like an 'ä' or a whitespace would have created a endless loop.

Co-authored-by: Sven Kröger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL encoded characters when use 'prefix_and_default'
2 participants
@szwenni @kazupon