-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(meta): add missing hid
to icon tags
#428
Conversation
The favicon head links were pushed without `hid` and `name` and they weren't deduplicated in `mergeMeta`. As a result they were appended every time the page was visited, causing a memory leak and crashing the server after some time.
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
=======================================
Coverage 85.28% 85.28%
=======================================
Files 9 9
Lines 367 367
Branches 122 122
=======================================
Hits 313 313
Misses 54 54
Continue to review full report at Codecov.
|
hid
to icon tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The favicon head links were pushed without
hid
andname
and they weren't deduplicated inmergeMeta
:pwa-module/lib/meta.utils.js
Lines 13 to 19 in 245aadc
As a result they were appended every time the page was visited, causing a memory leak and crashing the server after some time.