Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let 404s surface when auth middleware applied globally. #127

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Let 404s surface when auth middleware applied globally. #127

merged 1 commit into from
Apr 10, 2018

Conversation

benmccallum
Copy link
Contributor

@benmccallum benmccallum commented Apr 9, 2018 •
edited
Loading

As logged in issue #126, when the auth middleware is applied globally, non-authenticated users who hit non-existant routes (e.g. /asdf/asdf) get redirected to the login page. IMO, these should flow through to the 404 error page.

Notes:

  • Borrowed the getMatchedComponents method from the Nuxt core utils.
  • I hope I'm not opening up any potential security hole here?! Sanity check would be awesome

@pi0 pi0 merged commit c1b4cfd into nuxt-community:dev Apr 10, 2018
@benmccallum benmccallum mentioned this pull request Apr 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benmccallum @pi0