Resolve default namespaces for Queries and Mutations.

[robsontenorio]

Related Issue(s)

Resolves/improves #384

PR Type

Improvement

Changes

This is a improvement about how default namespaces are handled by fields.

Configs in lighthouse.php allow us to define default namespaces for Models, Queries, Mutations ...
But, when using a custom resolver it does not use "default namespaces" configs to resolve the class namespaces.

WITHOUT this PR we must set fullpath for namespace on @group or @field directive. Otherwise a class not found is thrown.

extend type Mutation{
  updateUser(name: String) @field(resolver: "App\\Http\\GraphQL\\Mutations\\UserMutation@update")
}

extend type Mutation @group(namespace:  "App\\Http\\GraphQL\\Mutations"){
  updateUser(name: String) @field(resolver: "UserMutation@update")
}

WITH this PR we can simple do this

extend type Mutation{
  updateUser(name: String) @field(resolver: "UserMutation@update")
}

Breaking changes

There is no breaking changes.

[spawnia]

This implementation might cause some really weird issues.

For example, if i have a mutation and a query that are defined in the same way, this will end
up resolving to the mutation class every time.

[spawnia]

Given this schema:

type Query {
  foo: Int field(resolver: "Foo@foo")
}

type Mutation {
  foo: Int field(resolver: "Foo@foo")
}

Now, if you have App\Http\GraphQL\Queries\Foo and App\Http\GraphQL\Mutations\Foo, this will always match the latter.

[robsontenorio]

@spawnia what do you mean with "if i have a mutation and a query that are defined in the same way"?

[robsontenorio]

@spawnia Ok, i got it.

But do you see what i'm trying to achieve? I am beginner with LightHouse. If you give some directions i can handle it.

[yaquawa]

@group is fine for me so far.
Just a piece of code can provide you more clarity.
Also this is the style Laravel follows too.

[robsontenorio]

I was trying to keep the schema clean. If there are default namespaces you do not need @group(namespace). But if PR is not compliant with LightHouse, it can be closed by maintainers