Remove expired members from subscription topic stored in Redis set map #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirills-morozovs
force-pushed
the
patch-1
branch
from
10f59eb
to
712823c
Compare
|
Thank you, released with https://github.com/nuwave/lighthouse/releases/tag/v6.43.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When lighthouse subscriptions storage TTL is set every new subscription to channel will create a redis key with channel serializzed information and add the channel id to a map set related to specific topic and both keys will have TTL, but when channel is expired or closed without a webhook triggered the map set will keep filling with "dead" channels,
subscribersByTopicmethod will already filter out the channel ids that expired, so this PR is going to collect those missing channel keys and then run SREM command to remove them from set map