Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of resolve() helper with Lumen-compatible app() #1305

Merged
merged 2 commits into from
Apr 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ You can find and compare releases at the [GitHub release page](https://github.co
### Fixed

- Fix nested mutations with multiple `belongsTo` relations at the same level https://github.com/nuwave/lighthouse/pull/1285
- Avoid race condition that occurs when using `Cache::has()` https://github.com/nuwave/lighthouse/pull/1290Adds
- Avoid race condition that occurs when using `Cache::has()` https://github.com/nuwave/lighthouse/pull/1290
- Replace usage of `resolve()` helper with Lumen-compatible `app()` https://github.com/nuwave/lighthouse/pull/1305

### Changed

Expand Down
2 changes: 1 addition & 1 deletion src/Schema/Directives/RulesDirective.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public function rules(): array
// resolve any given rule where a corresponding class exists.
foreach ($rules as $key => $rule) {
if (class_exists($rule)) {
$rules[$key] = resolve($rule);
$rules[$key] = app($rule);
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/Schema/Directives/RulesForArrayDirective.php
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public function rules(): array
// resolve any given rule where a corresponding class exists.
foreach ($rules as $key => $rule) {
if (class_exists($rule)) {
$rules[$key] = resolve($rule);
$rules[$key] = app($rule);
}
}

Expand Down